Атанас обнови решението на 21.03.2014 13:22 (преди почти 11 години)
+class Rank:
+ def __init__(self, symbol):
+ self.symbol = symbol
+
+ def __eq__(self, other):
+ return self.symbol == other.symbol
+
+
+class Ace(Rank):
+ def __init__(self):
+ self.symbol = 'A'
+
+ def __eq__(self, other):
+ return Rank.__eq__(self, other)
+
+ def __str__(self):
+ return 'Ace'
+
+ @classmethod
+ def name(cls):
+ return cls
+
+
+class Two(Rank):
+ def __init__(self):
+ self.symbol = '2'
+
+ def __eq__(self, other):
+ return Rank.__eq__(self, other)
+
+ def __str__(self):
+ return 'Two'
+
+ @classmethod
+ def name(cls):
+ return cls
+
+
+class Three(Rank):
+ def __init__(self):
+ self.symbol = '3'
+
+ def __eq__(self, other):
+ return Rank.__eq__(self, other)
+
+ def __str__(self):
+ return 'Three'
+
+ @classmethod
+ def name(cls):
+ return cls
+
+
+class Four(Rank):
+ def __init__(self):
+ self.symbol = '4'
+
+ def __eq__(self, other):
+ return Rank.__eq__(self, other)
+
+ def __str__(self):
+ return 'Four'
+
+ @classmethod
+ def name(cls):
+ return cls
+
+
+class Five(Rank):
+ def __init__(self):
+ self.symbol = '5'
+
+ def __eq__(self, other):
+ return Rank.__eq__(self, other)
+
+ def __str__(self):
+ return 'Five'
+
+ @classmethod
+ def name(cls):
+ return cls
+
+
+class Six(Rank):
+ def __init__(self):
+ self.symbol = '6'
+
+ def __eq__(self, other):
+ return Rank.__eq__(self, other)
+
+ def __str__(self):
+ return 'Six'
+
+ @classmethod
+ def name(cls):
+ return cls
+
+
+class Seven(Rank):
+ def __init__(self):
+ self.symbol = '7'
+
+ def __eq__(self, other):
+ return Rank.__eq__(self, other)
+
+ def __str__(self):
+ return 'Seven'
+
+ @classmethod
+ def name(cls):
+ return cls
+
+
+class Eight(Rank):
+ def __init__(self):
+ self.symbol = '8'
+
+ def __eq__(self, other):
+ return Rank.__eq__(self, other)
+
+ def __str__(self):
+ return 'Eight'
+
+ @classmethod
+ def name(cls):
+ return cls
+
+
+class Nine(Rank):
+ def __init__(self):
+ self.symbol = '9'
+
+ def __eq__(self, other):
+ return Rank.__eq__(self, other)
+
+ def __str__(self):
+ return 'Nine'
+
+ @classmethod
+ def name(cls):
+ return cls
+
+
+class Ten(Rank):
+ def __init__(self):
+ self.symbol = '10'
+
+ def __eq__(self, other):
+ return Rank.__eq__(self, other)
+
+ def __str__(self):
+ return 'Ten'
+
+ @classmethod
+ def name(cls):
+ return cls
+
+
+class Jack(Rank):
+ def __init__(self):
+ self.symbol = 'J'
+
+ def __eq__(self, other):
+ return Rank.__eq__(self, other)
+
+ def __str__(self):
+ return 'Jack'
+
+ @classmethod
+ def name(cls):
+ return cls
+
+
+class Queen(Rank):
+ def __init__(self):
+ self.symbol = 'Q'
+
+ def __eq__(self, other):
+ return Rank.__eq__(self, other)
+
+ def __str__(self):
+ return 'Queen'
+
+ @classmethod
+ def name(cls):
+ return cls
+
+
+class King(Rank):
+ def __init__(self):
+ self.symbol = 'K'
+
+ def __eq__(self, other):
+ return Rank.__eq__(self, other)
+
+ def __str__(self):
+ return 'King'
+
+ @classmethod
+ def name(cls):
+ return cls
+
+
+class Suit:
+ def __init__(self, color):
+ self.color = color
+
+ def __eq__(self, other):
+ return self.color == other.color
+
+
+class Hearts(Suit):
+ def __init__(self):
+ self.color = 'red'
+
+ def __eq__(self, other):
+ return str(self) == str(other)
+
+ def __str__(self):
+ return 'Hearts'
+
+ @classmethod
+ def name(cls):
+ return cls
+
+
+class Diamonds(Suit):
+ def __init__(self):
+ self.color = 'red'
+
+ def __eq__(self, other):
+ return str(self) == str(other)
+
+ def __str__(self):
+ return 'Diamonds'
+
+ @classmethod
+ def name(cls):
+ return cls
+
+
+class Spades(Suit):
+ def __init__(self):
+ self.color = 'black'
+
+ def __eq__(self, other):
+ return str(self) == str(other)
+
+ def __str__(self):
+ return 'Spades'
+
+ @classmethod
+ def name(cls):
+ return cls
+
+
+class Clubs(Suit):
+ def __init__(self):
+ self.color = 'black'
+
+ def __eq__(self, other):
+ return str(self) == str(other)
+
+ def __str__(self):
+ return 'Clubs'
+
+ @classmethod
+ def name(cls):
+ return cls
+
+
+class Card:
+ def __init__(self, rank, suit):
+ self._rank = rank()
+ self._suit = suit()
+
+ @property
+ def rank(self):
+ return self._rank
+
+ @property
+ def suit(self):
+ return self._suit
+
+ def __eq__(self, other):
+ return self.rank == other.rank and \
+ self.suit == other.suit
+
+ def __str__(self):
+ return str(self.rank) + ' of ' + str(self.suit)
+
+ def __repr__(self):
+ return '<Card ' + str(self) + '>'
+
+ @classmethod
+ def name(cls):
+ return cls
+
+
+RANKS = {
+ str(Two()): Two.name(), str(Three()): Three.name(),
+ str(Four()): Four.name(), str(Five()): Five.name(),
+ str(Six()): Six.name(), str(Seven()): Seven.name(),
+ str(Eight()): Eight.name(), str(Nine()): Nine.name(),
+ str(Ten()): Ten.name(), str(Jack()): Jack.name(),
+ str(Queen()): Queen.name(), str(King()): King.name(),
+ str(Ace()): Ace.name()
+}
+
+
+SUITS = {
+ str(Clubs()): Clubs.name(), str(Diamonds()): Diamonds.name(),
+ str(Hearts()): Hearts.name(), str(Spades()): Spades.name()
+}
+
+
+class CardCollection:
+ def __init__(self, collection=[]):
+ self.collection = list(collection)
+
+ def __getitem__(self, index):
+ return self.collection[index]
+
+ def __len__(self):
+ return len(self.collection)
+
+ def __repr__(self):
+ return str([repr(card) for card in self])
+
+ def draw(self, index):
+ drawn_card = self.collection[index]
+ self.collection.remove(drawn_card)
+ return drawn_card
+
+ def draw_from_top(self):
+ return self.draw(len(self) - 1)
+
+ def draw_from_bottom(self):
+ return self.draw(0)
+
+ def top_card(self):
+ return self[len(self) - 1]
+
+ def bottom_card(self):
+ return self[0]
+
+ def add(self, card):
+ self.collection.append(card)
+
+ def index(self, card):
+ return self.collection.index(card)
+
+
+def StandardDeck():
+ suit_order = ['Diamonds', 'Clubs', 'Hearts', 'Spades']
+ rank_order = [
+ 'King', 'Queen', 'Jack', 'Ten', 'Nine',
+ 'Eight', 'Seven', 'Six', 'Five', 'Four',
+ 'Three', 'Two', 'Ace'
+ ]
+ collection = [Card(RANKS[rank], SUITS[suit]) for suit in suit_order
+ for rank in rank_order]
+ deck = CardCollection(collection)
+ return deck
+
+
+def BeloteDeck():
+ suit_order = ['Diamonds', 'Clubs', 'Hearts', 'Spades']
+ rank_order = [
+ 'King', 'Queen', 'Jack', 'Ten', 'Nine',
+ 'Eight', 'Seven', 'Ace'
+ ]
+ collection = [Card(RANKS[rank], SUITS[suit]) for suit in suit_order
+ for rank in rank_order]
+ deck = CardCollection(collection)
+ return deck
+
+
+def SixtySixDeck():
+ suit_order = ['Diamonds', 'Clubs', 'Hearts', 'Spades']
+ rank_order = ['King', 'Queen', 'Jack', 'Ten', 'Nine', 'Ace']
+ collection = [Card(RANKS[rank], SUITS[suit]) for suit in suit_order
+ for rank in rank_order]
+ deck = CardCollection(collection)
+ return deck
Няма нужда на всеки подклас на Rank да предефинираш __eq__. Този метод се наследява от базовия клас. Същото важи и за подкласовете на Suit.
def __init__(self, collection=[]): - това е много лоша идея. За подразбираща се стойност на използваш list, което е mutable
Освен тези неща, кода ти е разбираем. Въпреки това, бих те посъветвал да помислиш как да съкратиш решението си.
Hint: с type можеш да си дефинираш класове.
Да разбирам ли, че ако използвам кортеж за подразбираща се стойност т.е.def init(self, collection=()): гореспоменатият проблем не е на лице?
Също така, защо да не трябва да се предефинира eq за наследяващите Suit, като двата метода сравняват различни неща- цветове в единия случай, и имена в другия?
PS: "__" около init и eq не излизат като хората